Less granular reader packages#7620
Merged
adriansr merged 3 commits intoelastic:masterfrom Aug 1, 2018
Merged
Conversation
kvch
added
discuss
houndci-bot
reviewed
Jul 17, 2018
There was a problem hiding this comment.
exported type JSONReader should have comment or be unexported
houndci-bot
reviewed
Jul 17, 2018
There was a problem hiding this comment.
exported type JSONReader should have comment or be unexported
Contributor
Author
|
jenkins test this |
Contributor
Author
|
The failing test on Jenkins is unrelated to this PR. |
|
I like that |
kvch
force-pushed
the
refactor/filebeat/less-granular-readers
branch
from
fde83c6 to
d17e987
Compare
Contributor
Author
|
It's much better indeed. I've renamed it. |
kvch
added a commit
that referenced
this pull request
Aug 31, 2018
Cherry-pick of PR #7620 to 6.x branch. Original message: I created new packages: readjson: includes JSON and DockerJSON readline: includes LimitReader, StripNewLineReader, etc. I left multiline as is for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created new packages:
readjson: includesJSONandDockerJSONreadline: includesLimitReader,StripNewLineReader, etc.I left
multilineas is for now.